-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import extraction with Rust #581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
force-pushed
the
feature/rust
branch
3 times, most recently
from
March 12, 2024 20:23
9bd61b3
to
83e4b2a
Compare
mkniewallner
force-pushed
the
feature/rust
branch
6 times, most recently
from
March 13, 2024 01:45
7df67fe
to
e60c822
Compare
mkniewallner
force-pushed
the
feature/rust
branch
from
March 13, 2024 09:31
e60c822
to
7160a4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docs
is updatedDescription of changes
This PR adds Rust functionality to deptry. For now, the only part that is handled by Rust is the reading for
.py
files, parsing their AST and extracting the import statements. This PR also gives us a good starting point to potentially replace more parts of deptry with Rust. For a benchmark comparison of the speed improvement, see this comment.List of changes:
from deptry.rust import get_imports_from_py_files
0
now it is8
.Once this PR is approved, I will modify the 'required status checks before merging'.